Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .redirect to RequestOptions and support in fetch engine #448

Merged
merged 11 commits into from
Dec 2, 2024

Conversation

kormanowsky
Copy link
Contributor

No description provided.

@kormanowsky kormanowsky force-pushed the kormanowsky/fetch-redirect-support branch from e7baeff to 56a5da7 Compare November 6, 2024 09:47
@gretzkiy gretzkiy self-requested a review November 15, 2024 07:34
Copy link
Member

@gretzkiy gretzkiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В движке xhr тоже нужно поддержать, если возможно

@kormanowsky
Copy link
Contributor Author

@gretzkiy

Не нашел возможности поддержки такого в XHR.
Плюс даже с fetch() это по-разному работает в браузере и в ноде.
Сейчас предполагается использовать только в ноде, так как там в случае redirect manual можно прочитать заголовки ответа, а в браузере - нет. А в ноде XHR по дефолту нет.
Поэтому кажется это и не нужно там?

@kormanowsky kormanowsky requested a review from gretzkiy November 18, 2024 10:34
Copy link
Contributor

@shining-mind shining-mind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Только CHANGELOG надо заполнить

@kormanowsky kormanowsky force-pushed the kormanowsky/fetch-redirect-support branch from 66d4876 to bfb2c5b Compare December 2, 2024 08:27
@kormanowsky kormanowsky force-pushed the kormanowsky/fetch-redirect-support branch from bfb2c5b to 2f9ffab Compare December 2, 2024 08:27
@kormanowsky kormanowsky merged commit b8ac308 into v4 Dec 2, 2024
4 checks passed
@kormanowsky kormanowsky deleted the kormanowsky/fetch-redirect-support branch December 2, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants