fix: empty string in arrayBuffer #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItMaga
requested review from
kobezzza and
shining-mind
and removed request for
kobezzza and
shining-mind
shining-mind
approved these changes
Oct 24, 2024
kobezzza
approved these changes
Oct 30, 2024
alexeishcherbina
pushed a commit
that referenced
this pull request
Dec 4, 2024
* fix: empty string in arrayBuffer * chore: linter
gretzkiy
added a commit
that referenced
this pull request
Dec 9, 2024
…ponse fix: empty string in arrayBuffer (#447)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание проблемы
Когда приходит заголовок
Content-Type: application/octet-stream, может в ответе прийти пустая строка. Например, так происходит при некоторых условиях, в нодовой библиотеке http-outgoing, и в этом случае у нас падает ошибкаTypeError("Can't read response data as ArrayBuffer"). Как я понимаю, пустая строка с таким заголовком является валидным