NNN -> gh->extStringArray refactor

Utumno · Jun 21, 2015 · e659c6b · e659c6b
1 parent 2118405
commit e659c6b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/api/loadorder.cpp b/src/api/loadorder.cpp
@@ -55,7 +55,7 @@ LIBLO unsigned int lo_get_load_order(lo_game_handle gh, char *** const plugins,
     unsigned int successRetCode = LIBLO_OK;
 
     //Free memory if in use.
-    if (gh->extStringArray != nullptr) {
+    if (gh->extStringArray != nullptr) { // (ut) this is just a global allocated array ?
         for (size_t i = 0; i < gh->extStringArraySize; i++)
             delete[] gh->extStringArray[i];
         delete[] gh->extStringArray;
@@ -70,7 +70,7 @@ LIBLO unsigned int lo_get_load_order(lo_game_handle gh, char *** const plugins,
             try {
                 gh->loadOrder.CheckValidity(*gh);
             }
-            catch (error& e) {
+            catch (error& e) { // TODO(ut): make sure we only get a LIBLO_WARN_INVALID_LIST here
                 successRetCode = c_error(e);
             }
         }

diff --git a/src/backend/plugins.cpp b/src/backend/plugins.cpp
@@ -83,6 +83,7 @@ namespace liblo {
             return ret;
         }
         catch (std::exception&) {
+            // TODO(ut): log it !
             return false;
         }
     }