Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yda 6066 update generate openapi py3 #539

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

stsnel
Copy link
Member

@stsnel stsnel commented Dec 23, 2024

No description provided.

lwesterhof and others added 2 commits December 23, 2024 20:15
Update generate-openapi script so that it works
correctly with Python 3.

This includes::
- Extracting functions to make code easier to understand.
- Instead of loading the ruleset and using custom instrumentation to
  inspect it, collect properties of API rules using the built-in
  AST module. This removes the need to update the OpenAPI script as
  dependencies change, since we no longer need to ensure we have stub
  code in place to be able to run the instrumentation.
@stsnel stsnel force-pushed the YDA-6066-update-generate-openapi-py3 branch from 92a8169 to cc1e724 Compare December 23, 2024 21:02
@stsnel stsnel marked this pull request as ready for review December 23, 2024 21:03
Copy link
Member

@lwesterhof lwesterhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@stsnel stsnel merged commit 17f0e85 into development Jan 7, 2025
8 checks passed
@stsnel stsnel deleted the YDA-6066-update-generate-openapi-py3 branch January 7, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants