PoC with response and API caching #372
Open
+583
−403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwesterhof
force-pushed
the
portal-caching
branch
12 times, most recently
from
42111c9 to
00d8cbc
Compare
lwesterhof
force-pushed
the
portal-caching
branch
2 times, most recently
from
549043c to
175d723
Compare
lwesterhof
force-pushed
the
portal-caching
branch
from
175d723 to
3e922b4
Compare
|
Perhaps it is already in your TODOs, a note is that I encountered an error of flask_session version is outdated in the requirement.txt. Thus, importing flask_session.filesystem reported an error. Upgrading flask_session to 0.8.0 resolved the issue. |
|
Yeah, I already upgraded the versions in development. Will merge with this branch soon. |
claravox
reviewed
Jan 8, 2025
| def make_key(api_key: Optional[str] = None) -> str: | ||
| """Generate a cache key based on the request and authentication status. | ||
|
|
||
| :param api_key: Optional custom key indentifying API endpoint. If None, defaults to request endpoint and method |
There was a problem hiding this comment.
Suggested change
| :param api_key: Optional custom key indentifying API endpoint. If None, defaults to request endpoint and method | |
| :param api_key: Optional custom key identifying API endpoint. If None, defaults to request endpoint and method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds caching for Flask responses to avoid re-rendering templates, improving performance. It introduces API caching for a limited set of endpoints with defined timeouts.
Additionally, some API calls have been moved to the client side to leverage the template cache, further enhancing efficiency. Certain API calls will trigger cache clearing to ensure users receive up-to-date information.