Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

role poetry: remove and install via pipx instead #222

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ The status of a role is either Experimental or Supported. Supported roles are su
- [miniconda](roles/miniconda.md)
- [nginx_reverse_proxy](roles/nginx_reverse_proxy.md)
- [nginx_uwsgi](roles/nginx_uwsgi.md)
- [poetry](roles/poetry.md)
- [pip](roles/pip.md) install pip
- [pipx_install_systemwide](roles/pipx_install_systemwide.md) install pip packages in a shared directory for all users
- [pyenv](roles/pyenv.md) install pyenv and use it to install custom python version
Expand Down
4 changes: 2 additions & 2 deletions docs/playbooks/python-workbench.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Ubuntu .
## Description
The Linux distribution influences which Python3 and pip3 versions are installed system-wide. Users should not install python packages using the system python interpreter, since this may break system packages. This component therefore installs `pyenv` and via the `runonce` role, so that each user on the system can manage their own Python environment. `pyenv` and `poetry` are installed (in userspace) the first time the user logs in.

For additional development convenience, `poetry` and `miniconda` are also intalled on a per-user basis. If users want to use `miniconda`, they have to manually run `conda init` in their shell (this is not done by default, because it may interfere with users' workflows if they do not want to use `conda`).
For additional development convenience, `poetry` (via [pipx](../roles/pipx_install_systemwide.md)) and `miniconda` (via [runonce](../roles/runonce.md)) are also installed. If users want to use `miniconda`, they have to manually run `conda init` in their shell (this is not done by default, because it may interfere with users' workflows if they do not want to use `conda`).

## Variables

Expand All @@ -26,7 +26,7 @@ For additional development convenience, `poetry` and `miniconda` are also intall

- role [runonce](../roles/runonce.md)
- role [pyenv](../roles/pyenv.md)
- role [runonce](../roles/poetry.md)
- role [runonce](../roles/pipx_install_systemwide.md)
- role [miniconda](../roles/miniconda.md)

## History
Expand Down
4 changes: 3 additions & 1 deletion molecule/playbook-python-workbench/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
register: expected_files
with_items:
- 01_pyenv-install.sh
- 10-poetry.sh

- name: Assert expected files exist
ansible.builtin.assert:
Expand All @@ -27,3 +26,6 @@
ansible.builtin.assert:
that:
- '"3.8" in python_version.stdout_lines[0]'

- name: Test poetry
ansible.builtin.shell: su -c "bash -ic 'poetry about'" - testuser
5 changes: 4 additions & 1 deletion playbooks/python-workbench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,7 @@
- role: pyenv
vars:
pyenv_default_python: "{{ default_python_version | default('system-latest') }}"
- role: poetry
- role: pipx_install_systemwide
vars:
pipx_install_systemwide_packages:
- poetry
3 changes: 0 additions & 3 deletions playbooks/roles/poetry/defaults/main.yml

This file was deleted.

15 changes: 0 additions & 15 deletions playbooks/roles/poetry/files/10-poetry.sh

This file was deleted.

5 changes: 0 additions & 5 deletions playbooks/roles/poetry/meta/main.yml

This file was deleted.

8 changes: 0 additions & 8 deletions playbooks/roles/poetry/molecule/default/converge.yml

This file was deleted.

9 changes: 0 additions & 9 deletions playbooks/roles/poetry/molecule/default/molecule.yml

This file was deleted.

18 changes: 0 additions & 18 deletions playbooks/roles/poetry/molecule/default/verify.yml

This file was deleted.

11 changes: 0 additions & 11 deletions playbooks/roles/poetry/tasks/main.yml

This file was deleted.

21 changes: 0 additions & 21 deletions playbooks/roles/poetry/tasks/system_wide.yml

This file was deleted.

Loading