Refactor terraform code that automates creation of zip for source files #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltaskew
approved these changes
Jul 15, 2024
|
|
||
| # Filenames are constructed to preserve source subdirectory structure within /temp | ||
| filename = "${path.module}/temp/${ | ||
| contains(fileset(local.usl_lib_dir, "**/"), element(local.source_files, count.index)) ? |
There was a problem hiding this comment.
might consider making these three separate 'to_temp_dir' resources rather than one with a contains switch if you think that'd be more readable
It should - but i'm not able to test out the template stuff locally. with this approach, we aren't able to gen a local zip file when we do plan. i believe we will need to hit terraform apply for this to actually run e2e. the dev plan in the description should have the diff for the files that will get created if you can take a look to sanity check! |
rsutormin
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to redo the tf code that automates the way we are constructing the cloud function zip file with source files due to tf's lack of support for properly archiving binary files without forcing us to encode it (see: hashicorp/terraform-provider-archive#149). We need a workaround to support adding python wheel files (binary) in order to build requirements.txt properly.
Dev tf plan output
Reference: https://stackoverflow.com/questions/56916719/is-there-a-way-to-define-multiple-source-file-for-terraform-archive-provider