Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resizeObserver action #33

Merged
merged 4 commits into from
Mar 5, 2024
Merged

add resizeObserver action #33

merged 4 commits into from
Mar 5, 2024

Conversation

mitchthorson
Copy link
Contributor

Takes inspiration from here and here to make it easy to track an element's size when Svelte's built-in bind:clientWidth feature runs into problems.

@mitchthorson mitchthorson requested a review from benkates March 2, 2024 18:29
@benkates
Copy link
Contributor

benkates commented Mar 4, 2024

Good stuff. Love the precedent of starting an actions folder!

What do you think about adding a note to the mdx about Svelte 5's native bind:clientWidth using it under the hood? For when we inevitably start using Svelte 5 at some point. Issue here

@mitchthorson
Copy link
Contributor Author

@benkates my thinking is we cross that bridge when we get there. we don't yet know how complex it will be to upgrade to svelte 5, so we should probably wait to figure out or document anything svelte 5 related until it releases and we've assessed how best to handle it with this library.

@mitchthorson
Copy link
Contributor Author

Taking another look, I think you're right it is a good idea to make a note explicitly in the docs.

@mitchthorson mitchthorson merged commit 9b9b210 into main Mar 5, 2024
1 check passed
@mitchthorson mitchthorson deleted the add-resize-action branch March 5, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants