Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Path Dependencies #88

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Add Path Dependencies #88

wants to merge 29 commits into from

Commits on Jun 8, 2022

  1. started?

    @u-train
    u-train committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5c449aa View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Added test for path dependency

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    5848f25 View commit details
    Browse the repository at this point in the history

  2. the first stable working thing.

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    d495aaa View commit details
    Browse the repository at this point in the history

  3. Stop packages using path package locations 

    This follows Cargo's convention firstly for good reason.
Stops a footgun where a package is dependent on a system-specific path.
    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c58ccf2 View commit details
    Browse the repository at this point in the history

  4. Adding comments explaining some reasoning.

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    ab84f4b View commit details
    Browse the repository at this point in the history

  5. Added more of clippy's suggestions

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    db2f170 View commit details
    Browse the repository at this point in the history

  6. Cleaned up with .all() instead of using .filter()

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    ccde971 View commit details
    Browse the repository at this point in the history

  7. More clippy business

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    fc4db25 View commit details
    Browse the repository at this point in the history

  8. Cleaned crate::package_origin usage in match

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    ec71c39 View commit details
    Browse the repository at this point in the history

  9. Missed last

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    187f37b View commit details
    Browse the repository at this point in the history

  10. More documentation

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    7d895e3 View commit details
    Browse the repository at this point in the history

  11. Added todo wrt relative paths

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    59b6633 View commit details
    Browse the repository at this point in the history

  12. Cleaned up code for installation and forward-slash!

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    e7b90b9 View commit details
    Browse the repository at this point in the history

  13. Should be using package_id ...

    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    1ab2d9d View commit details
    Browse the repository at this point in the history

  14. resolve now accepts a root_dir 

    Useful to resolve relative package paths.
    @u-train
    u-train committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    b3497cc View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. Forgot to implement serializatoin for all origins

    @u-train
    u-train committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    ec87fe7 View commit details
    Browse the repository at this point in the history

  2. Hacky way to make reoslution responsible for path

    @u-train
    u-train committed Jun 11, 2022
    Configuration menu
    Copy the full SHA
    d4a1312 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. Simplify leak

    @u-train
    u-train committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    008eb1b View commit details
    Browse the repository at this point in the history

  2. Fixed bug where it forgets to join relative path

    @u-train
    u-train committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    7175e88 View commit details
    Browse the repository at this point in the history

  3. Add a new test-case for path dependencies

    @u-train
    u-train committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    a8c8079 View commit details
    Browse the repository at this point in the history

  4. Cleaned up code

    @u-train
    u-train committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    0968a28 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Use fs+path/here instead of just the path 

    Allows parsing to fail and not be infalliable (leading to ambugities)
    @u-train
    u-train committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    cd51129 View commit details
    Browse the repository at this point in the history

  2. Added check to prevent any unexpected path dependencies

    @u-train
    u-train committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    1815203 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Added check in backend and added publish test

    @u-train
    u-train committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    4f3b324 View commit details
    Browse the repository at this point in the history

  2. Changed readme with fs format

    @u-train
    u-train committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    2c4d153 View commit details
    Browse the repository at this point in the history

  3. CRLF to LF !!!!

    @u-train
    u-train committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    b63ad47 View commit details
    Browse the repository at this point in the history

  4. more CRLF to LF.. Windows!!!

    @u-train
    u-train committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    87a6e36 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Fix gitattribute

    @u-train
    u-train committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    417da72 View commit details
    Browse the repository at this point in the history

  2. Reset to capture the files with wrong newlines. 

    LF should've of been used instead of CRLF from windows.
    @u-train
    u-train committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    96b4c01 View commit details
    Browse the repository at this point in the history