Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #328

Merged
merged 21 commits into from
Nov 21, 2024

Conversation

ArielBlanco1990
Copy link
Contributor

Related to Issue

Fixes #325, #324, #323, #322, #317, #306, #305, #190, #189, #167, #166, #165, #164, #153, #141, #130, #105, #93

Description

This PR updates multiple project templates and dependencies to address known vulnerabilities in DNN 09.08.00 and ensure compatibility with DNN 09.11.00. Key changes include:

  • Updated templates for:

Auth-Provider, MVC, MVC-SPA, Vue3JS, Library-ScheduledJob, Library, SkinObject, Solution, WebForms, VueJs, ReactJs, and Angular.

  • Dependency Updates:

Fixed vulnerabilities in the following libraries:

  • cross-spawn:
    From 7.0.3 and 5.1.0 → Updated to 7.0.5.
  • axios:
    From 1.6.0 → Updated to 1.6.3.
  • body-parser:
    From 1.20.2 → Updated to 1.20.3.
  • follow-redirects:
    From 1.15.3 → Updated to 1.15.6.
  • got:
    From 6.7.1 → Updated to 11.8.6.
  • System.Web.Mvc:
    From 5.1.20821.0 → Updated to 5.2.9-61139.
  • log4net:
    From 1.2.10.0 → Updated to 2.0.10.
  • SharpZipLib:
    From 0.86.0.518 → Updated to 1.4.2.
  • dotnetnuke.core:
    From 9.8.0 → Updated to 9.11.0.

Upgraded DNN version from 09.08.00 to 09.11.00.

  • Removed obsolete references:

Deleted generators/solution/templates/References/DNN/09.08.00.

  • Configuration updates:

Updated Module.csproj and tsconfig.json.

How Has This Been Tested?

  • Verified that all updated templates compile successfully in both Debug and Release modes.
  • Generated installers for all templates and validated their installation on a clean solution.

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@WillStrohl WillStrohl added the enhancement New feature or request label Nov 19, 2024
@WillStrohl WillStrohl added this to the 01.14.00 milestone Nov 19, 2024
Copy link
Contributor

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielBlanco1990 There are a number of minor updates necessary for this to follow the version number pattern put in place previously for the DNN version number.

We may need to remove the DotNetNuke.Web.Deprecated reference from all projects.

Finally, do we need to include the *.dll.config files? If not, please remove them from the PR.

generators/common/src-library/packages.config Outdated Show resolved Hide resolved
generators/library-scheduledjob/templates/library.csproj Outdated Show resolved Hide resolved
generators/library/templates/library.csproj Outdated Show resolved Hide resolved
generators/mvc-spa/templates/Module.csproj Outdated Show resolved Hide resolved
generators/mvc-spa/templates/packages.config Outdated Show resolved Hide resolved
generators/spa/templates/common/manifest.dnn Outdated Show resolved Hide resolved
generators/webforms/templates/Module.csproj Outdated Show resolved Hide resolved
generators/webforms/templates/Module.csproj Outdated Show resolved Hide resolved
generators/webforms/templates/manifest.dnn Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ArielBlanco1990
Copy link
Contributor Author

@WillStrohl FYI: I am testing all the changes I have made and will create the commits when the tests are finished.

Replaced <%= dnnBuildVersionShort %> and <%= dnnBuildVersion %> where necessary.

Removed reference to DotNetNuke.Web.Deprecated Version="9.10.2"
@ArielBlanco1990
Copy link
Contributor Author

@WillStrohl Everything is ready, I have checked each of the solutions after fixing the details indicated and they all work correctly. You can check the PR again.

Copy link
Contributor

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit e61e59a into UpendoVentures:master Nov 21, 2024
1 of 2 checks passed
@WillStrohl
Copy link
Contributor

Also resolves #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2024-21538 (High) detected in cross-spawn-7.0.3.tgz, cross-spawn-5.1.0.tgz
2 participants