Add options to pass redisPassword #216
Conversation
|
Hello, I try to use your exporter with a Redis cluster that had a password with special characters. Take as example : password = suds*$d@?2\ because of these characters, I was not able to connect the IoRedis. Even in using url encode. So I develop a PR to allow passing Redis Password as an options |
|
This can be added to the URL infront of the host, instead of requiring a separate env variable. |
|
But if you have any special characters in the password, you cannot add it to the URL. Even if you use url encode. |
src/metricCollector.ts
Outdated
| @@ -42,9 +44,11 @@ export class MetricCollector { | |||
| opts: MetricCollectorOptions, | |||
| registers: Registry[] = [globalRegister], | |||
| ) { | |||
| const { logger, autoDiscover, redis, metricPrefix, ...bullOpts } = opts; | |||
| const { logger, autoDiscover, redis, redisPassword, metricPrefix, ...bullOpts } = opts; | |||
| logger.info('connection to redis ' + redis + ' with password ' + redisPassword); | |||
There was a problem hiding this comment.
it's a shame you log the password there... I had to make a fork just to remove it and re-publish
There was a problem hiding this comment.
Used for debugging and forgot to remove it.
thanks @maxaggedon
|
Other than special characters, having a separate environnement variable for password allows to retrieve it from a secret if you use this image in kubernetes |
|
hi @maxaggedon |
|
@AnthonyDurussel I reported a potential security issue because I saw it, but I don't have write access on this repo, sorry. |
Description
This is a
Checklists
Commit style
Changes are on a branch with a descriptive name eg.
fix/missing-queue,docs/setup-guideCommits start with one of
feat:fix:docs:chore:or similarNo excessive commits, eg: there should be no
fix:commits for bugs that existed only on the PR branch (see guide-to-interactive-rebasing)Protected files
The following files should not change unless they are directly a part of your change.
yarn.lock(unless package.json is also modified, then only the new/updated package should be changed here)package.json(renovate bot should handle all routine updates)package-lock.json(Should not exist as this project uses yarn)tsconfig.json(only make it stricter, making it more lenient requires more discussion)tslint.json(only make it stricter, making it more lenient requires more discussion)