Bug Fixes #23
Merged
Bug Fixes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ItzNxthaniel
commented
Nov 3, 2022
•
ItzNxthaniel
commented
- Change Title Match Mode to 3 which is an exact match. (Closes Possible incorrect window activating. #21)
- Fix reconnect click bug. (Closes Reconnection doesn't always work #16)
- Mouse snaps to imageCornerX - 20 and imageCornerY - 20 and then slides onto the middle of the button, creating hover event.
- Change Title Match Mode to be 3 which is exact match.
This seems to work 100% of the time on 1920x1080, a smaller window seems to work 2nd try.
jaredcat
requested changes
Nov 4, 2022
- Added a comment block explaining why it's done this way and why we change SendMode.
jaredcat
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.