OD metrics for CI #3269
Merged
OD metrics for CI #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-kmiecik
approved these changes
Jul 8, 2024
ds-filipknefel
requested changes
Jul 8, 2024
Comment on lines
+254
to
+255
| @click.option("--output_dir", type=str, help="Directory to structured output.") | ||
| @click.option("--source_dir", type=str, help="Directory to structured source.") |
There was a problem hiding this comment.
Could use clicks Path type here for more control over the parameter's value e.g. only directory, existance
There was a problem hiding this comment.
True but this should be applied to all ingest commands then - worth a separate PR.
mpolomdeepsense
requested changes
Jul 8, 2024
Co-authored-by: Michał Martyniak <[email protected]>
Co-authored-by: Michał Martyniak <[email protected]>
ds-filipknefel
approved these changes
Jul 9, 2024
| super().__post_init__() | ||
| self._document_paths = [ | ||
| path.relative_to(self.documents_dir) | ||
| for path in self.documents_dir.rglob("analysis/*/layout_dump/object_detection.json") |
There was a problem hiding this comment.
Maybe this path should be declared in some common file.
mpolomdeepsense
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OD metrics for CI