fix: use raw strings for regex patterns #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scanny
force-pushed
the
scanny/fix-syntax-error
branch
from
8d5a0bc to
bb69164
Compare
scanny
force-pushed
the
scanny/fix-syntax-error
branch
from
bb69164 to
978fb40
Compare
scanny
force-pushed
the
scanny/fix-syntax-error
branch
from
978fb40 to
f81aa4a
Compare
Coniferish
reviewed
May 16, 2024
| @@ -27,6 +27,7 @@ lint.select = [ | |||
| "UP018", # -- Unnecessary {literal_type} call like `str("abc")`. (rewrite as a literal) -- | |||
| "UP032", # -- Use f-string instead of `.format()` call -- | |||
| "UP034", # -- Avoid extraneous parentheses -- | |||
| "W", # -- Warnings, including invalid escape-sequence -- | |||
There was a problem hiding this comment.
Can you also make this change in .pre-commit-config.yaml and the Makefile?
There was a problem hiding this comment.
We moved the redundant specification of ruff configuration out of those two a while back. So this pyproject.toml is the authoritative source of ruff config now, a dividend of DRY :)
94535e3
Coniferish
approved these changes
May 16, 2024
Avoid `SyntaxWarning` and/or `SyntaxError` messages when importing `unstructured.nlp.patterns` by using raw strings (`"r"` prefix) for regex patterns which may contain `\x` character sequences not recognized by the Python parser for normal strings.
scanny
force-pushed
the
scanny/fix-syntax-error
branch
from
f81aa4a to
1894467
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid
SyntaxWarningand/orSyntaxErrormessages when importingunstructured.nlp.patternsby using raw strings ("r"prefix) for regex patterns which may contain\xcharacter sequences not recognized by the Python parser for normal strings.Fixes: #2495