feat(docx): add strategy parameter to partition_docx() #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coniferish
reviewed
May 15, 2024
| One of "hi_res", "fast", and a few others. These are available as class attributes on | ||
| `unstructured.partition.utils.constants.PartitionStrategy` but resolve to str values. | ||
| """ | ||
| return PartitionStrategy.HI_RES if self._strategy is None else self._strategy |
There was a problem hiding this comment.
Just want to double-check that it should default to hi_res, otherwise looks good
There was a problem hiding this comment.
Good call, I'll confirm with Matt :)
There was a problem hiding this comment.
k, yep, confirmed :)
scanny
force-pushed
the
scanny/add-strategy-param-to-docx
branch
from
1ce2649 to
2989187
Compare
scanny
force-pushed
the
scanny/add-strategy-param-to-docx
branch
from
2989187 to
efe5785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The behavior of an image sub-partitioner can be partially determined by the partitioning strategy, for example whether it is "hi_res" or "fast". Add this parameter to
partition_docx()so it can pass it along toDocxPartitionerOptionswhich will make it available to any image sub-partitioners.