Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astra DB: explicit projection when reading from Astra DB #3013

Conversation

hemidactylus
Copy link

In view of upcoming changes in the Astra DB Data API, this PR explicitly sets a projection every time a find command (or equivalent) is executed, in order to ensure all necessary fields of the document are returned by the API.

This occurs in the two method calls find_one and vector_find in the test test-ingest-astra-output.py.

With this change, future versions of the Data API, which may implement an exclude-vector-by-default policy, will not cause any disruption in these tests.

@potter-potter
Copy link
Contributor

potter-potter commented May 15, 2024

@hemidactylus Are there any code changes in the unstructured package needed for this? Or is it just in that test script that we are using to check our results?

If it is just this change, I will add to a current Unstructured PR. (easier to merge in that way)

#3003

@hemidactylus
Copy link
Author

Hi, @potter-potter, it is just the test script indeed. Please feel free to close this and apply the patch within another PR :)
... and thank you for taking care of it!

@potter-potter
Copy link
Contributor

Closing.
update added here:
#3003

@hemidactylus hemidactylus deleted the SL-astra-db-explicit-projection branch May 16, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants