Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paragraph grouper type hint #3002

Merged
merged 3 commits into from
May 10, 2024
Merged

paragraph grouper type hint #3002

merged 3 commits into from
May 10, 2024

Conversation

Coniferish
Copy link
Collaborator

Fix type hint for paragraph_grouper param. paragraph_grouper can be set to False, but the type hint did not not reflect this previously.

Copy link

sentry-io bot commented May 10, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: unstructured/partition/text.py

Function Unhandled Issue
_partition_text UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 0: invalid start byte ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Collaborator

@scanny scanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Coniferish Coniferish added this pull request to the merge queue May 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 10, 2024
@Coniferish Coniferish enabled auto-merge May 10, 2024 18:27
@Coniferish Coniferish added this pull request to the merge queue May 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2024
@Coniferish Coniferish added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 8eee14d May 10, 2024
42 checks passed
@Coniferish Coniferish deleted the jj/paragraph_grouper_type_hint branch May 10, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants