feat(pptx): partition_pptx() accepts strategy arg #2879
Merged
+42
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we move to adding pluggable sub-partitioners,
partition_pptx()
will need to become sensitive to thestrategy
argument, in particular when it is set to "hi_res". Up until now there were no expensive operations (inference, OCR, etc.) incurred while partitioning PPTX so this argument was ignored.After this PR,
partition_pptx()
still won't do anything with that value, other than pass it along to_PptxPartitionerOptions
for safe-keeping, but now its ready for use by aPicturePartitioner
(to come in a subsequent PR).