rfctr: prepare for adding metadata.orig_elements field #2647
Conversation
scanny
force-pushed
the
scanny/prep-for-orig-elements
branch
from
8aa85b7 to
fafcf46
Compare
| @@ -31,6 +31,7 @@ select = [ | |||
| ] | |||
| ignore = [ | |||
| "COM812", # -- over aggressively insists on trailing commas where not desireable -- | |||
| "PT005", # -- flags mock fixtures with names intentionally matching private method name -- | |||
| "PT011", # -- pytest.raises({exc}) too broad, use match param or more specific exception -- | |||
There was a problem hiding this comment.
Does this change need to be replicated in in .pre-commit-config.yaml and Makefile? (note at the top)
There was a problem hiding this comment.
Hmm, yeah, good call. I've removed those redundant explicit options definitions. Now they should be picked up from the pyproject.toml so it's the single source of truth on options.
| "method_mock", | ||
| "property_mock", | ||
| ) | ||
|
|
There was a problem hiding this comment.
Not that this needs to be changed, but isn't __all__ used to define what's imported when you use * to import, or is there another use?
There was a problem hiding this comment.
Yes, it is, but it also indicates what you are intentionally "exporting" and prevents ruff errors related to "xyz is imported but not used". That's why I have it here.
test_unstructured/unit_utils.py
Outdated
| # ------------------------------------------------------------------------------------------------ | ||
| # MOCKING FIXTURES | ||
| # ------------------------------------------------------------------------------------------------ | ||
| # These allow full-featured and type-save mocks to be created simply by adding a unit-test |
There was a problem hiding this comment.
type-save or type-safe?
There was a problem hiding this comment.
Yep, good catch. Fixed.
scanny
force-pushed
the
scanny/prep-for-orig-elements
branch
from
fafcf46 to
ac3295d
Compare
Add utility functions that allow robust mocks to be created by adding a simple unit-test fixture.
scanny
force-pushed
the
scanny/prep-for-orig-elements
branch
from
ac3295d to
b70647d
Compare
…IO#2647) **Summary** Some typing modernization in `elements.py` which will get changes to add the `orig_elements` metadata field. Also some additions to `unit_util.py` to enable simplified mocking that will be required in the next PR.
…IO#2647) **Summary** Some typing modernization in `elements.py` which will get changes to add the `orig_elements` metadata field. Also some additions to `unit_util.py` to enable simplified mocking that will be required in the next PR.
Summary
Some typing modernization in
elements.pywhich will get changes to add theorig_elementsmetadata field.Also some additions to
unit_util.pyto enable simplified mocking that will be required in the next PR.