rfctr(chunking): extract general-purpose objects to base #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scanny
force-pushed
the
scanny/extract-base-objects
branch
from
9ed8682 to
0298b1d
Compare
scanny
force-pushed
the
scanny/extract-base-objects
branch
from
0298b1d to
deaff54
Compare
Extract objects from `unstructured.title` that are not particular to that chunking strategy and place them in `unstructured.base` so they can be re-used by other chunking strategies. Also move the tests to `test_base.py`.
scanny
force-pushed
the
scanny/extract-base-objects
branch
from
deaff54 to
597b087
Compare
|
Thanks @christinestraub! :) |
Coniferish
pushed a commit
that referenced
this pull request
Dec 18, 2023
Many of the classes defined in `unstructured.chunking.title` are applicable to any chunking strategy and will shortly be used for the "by-character" chunking strategy as well. Move these and their tests to `unstructured.chunking.base`. Along the way, rename `TextPreChunkBuilder` to `PreChunkBuilder` because it will be generalized in a subsequent PR to also take `Table` elements such that inter-pre-chunk overlap can be implemented. Otherwise, no logic changes, just moves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the classes defined in
unstructured.chunking.titleare applicable to any chunking strategy and will shortly be used for the "by-character" chunking strategy as well.Move these and their tests to
unstructured.chunking.base.Along the way, rename
TextPreChunkBuildertoPreChunkBuilderbecause it will be generalized in a subsequent PR to also takeTableelements such that inter-pre-chunk overlap can be implemented.Otherwise, no logic changes, just moves.