-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix strategy test for api and linting #1840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coniferish
force-pushed
the
jj/188-unstructured-api-test
branch
from
October 23, 2023 17:18
991eff2
to
549d0d6
Compare
cragwolfe
reviewed
Oct 23, 2023
cragwolfe
reviewed
Oct 23, 2023
@cragwolfe would it be worth investigating why the same file in different formats is partitioned into different elements? |
cragwolfe
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes unstructured-api issue 188
The test and gist were using different versions of the same file (jpg/pdf), creating what looked like a bug when there wasn't one. The api is correctly using the
strategy
kwarg.Testing
Checkout to
main
Comment out the
@pytest.mark.skip
decorators for thetest_partition_via_api_with_no_strategy
testAdd an API key to your env:
from dotenv import load_dotenv; load_dotenv()
to the top of the file and haveUNS_API_KEY
defined in.env
Run
pytest test_unstructured/partition/test_api.py -k "test_partition_via_api_with_no_strategy"
^the test will fail
Checkout to this branch
pytest test_unstructured/partition/test_api.py -k "test_partition_via_api_with_no_strategy"
Other
make tidy
andmake check
made linting changes to additional files