-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roman/bugfix fix default language ingest option #1729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbiseck3
force-pushed
the
roman/ingest-lang-default-none
branch
from
October 12, 2023 12:28
6361bcb
to
f53622a
Compare
Comment on lines
+18
to
+20
"cat", | ||
"ita", | ||
"fra" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣 I mean...fair
...nstructured_ingest/expected-structured-output/Sharepoint/SitePages/This-is-a-title.html.json
Show resolved
Hide resolved
...ingest/expected-structured-output/local-single-file-with-encoding/fake-html-cp1252.html.json
Show resolved
Hide resolved
ryannikolaidis
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted some curiosities with respect to the auto languages, but that's out of the purview of this PR. changes here are gtg!
…es update (#1731) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rbiseck3 <[email protected]>
rbiseck3
force-pushed
the
roman/ingest-lang-default-none
branch
from
October 12, 2023 17:05
e579643
to
156389e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set language to None by default. Update ingest test to use local file used in language unit tests to validate.