Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roman/bugfix fix default language ingest option #1729

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

rbiseck3
Copy link
Contributor

Description

Set language to None by default. Update ingest test to use local file used in language unit tests to validate.

@rbiseck3 rbiseck3 linked an issue Oct 12, 2023 that may be closed by this pull request
@rbiseck3 rbiseck3 force-pushed the roman/ingest-lang-default-none branch from 6361bcb to f53622a Compare October 12, 2023 12:28
Comment on lines +18 to +20
"cat",
"ita",
"fra"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 I mean...fair

Copy link
Contributor

@ryannikolaidis ryannikolaidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted some curiosities with respect to the auto languages, but that's out of the purview of this PR. changes here are gtg!

rbiseck3 and others added 4 commits October 12, 2023 13:03
@rbiseck3 rbiseck3 force-pushed the roman/ingest-lang-default-none branch from e579643 to 156389e Compare October 12, 2023 17:05
@rbiseck3 rbiseck3 enabled auto-merge October 12, 2023 17:06
@rbiseck3 rbiseck3 added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 22e568c Oct 12, 2023
39 checks passed
@rbiseck3 rbiseck3 deleted the roman/ingest-lang-default-none branch October 12, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug/ingest language should not default to 'eng' but None
3 participants