build(test): skip full python matrix for most ingest tests #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use 3.10 for fixtures update
rbiseck3
reviewed
Oct 9, 2023
| echo "--------- RUNNING SCRIPT $script --- IGNORING FAILURES" | ||
| python_version=$(python --version 2>&1) | ||
|
|
||
| for test in "${all_tests[@]}"; do |
There was a problem hiding this comment.
can we add some documentation here on what this logic is meant to be handling? It's getting pretty complicated and reading bash logic comparisons are not the easiest.
There was a problem hiding this comment.
yep, totally fair. assuming this is about the conditional logic a few lines down, right? just dropped a comment on it, let me know if that covers it!
|
Small ask for some additional documentation, but otherwise looks good. Always a fan of anything that helps expedite the ingest tests. |
rbiseck3
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’re probably unfairly (to the test) making a large volume of new connections and requests to test services when all of our ingest tests run across the full python test matrix and when a lot of PRs a firing at once. Lets limit the full matrix run to a select few, but still have all ingest tests run on python v3.10. This is done by checking the version and skipping in ingest-test.sh.
Bonus: Bumps ingest test fixture workflow to use 3.10. This technically shouldn't make a difference, but since we're making 3.10 the default of the matrix strategy, it probably makes sense to use 3.10 for the ingest fixture generation as well for consistency.
Testing