-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roman/cli infer table arg #1685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small typo, otherwise LGTM from my end
6a0fbfb
to
f7e584d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a quick test? either unit or simply throw that option in an ingest test with a doc that with results that differ based on the setting?
test_unstructured_ingest/test-ingest-local-single-file-with-pdf-infer-table-structure.sh
Outdated
Show resolved
Hide resolved
059078c
to
5136a9d
Compare
quick suggestion on the changelog otherwise gtg! |
02bc7c5
to
cfa8141
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks for grabbing this!
This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rbiseck3 <[email protected]>
4093bcd
to
67cbce4
Compare
Description
Add new parameter to map to
skip_infer_table_types
partition arg. Applies to partition config which is set on all connectors.