Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roman/cli infer table arg #1685

Merged
merged 5 commits into from
Oct 12, 2023
Merged

roman/cli infer table arg #1685

merged 5 commits into from
Oct 12, 2023

Conversation

rbiseck3
Copy link
Contributor

@rbiseck3 rbiseck3 commented Oct 9, 2023

Description

Add new parameter to map to skip_infer_table_types partition arg. Applies to partition config which is set on all connectors.

@rbiseck3 rbiseck3 added bug Something isn't working ingest labels Oct 9, 2023
@rbiseck3 rbiseck3 linked an issue Oct 9, 2023 that may be closed by this pull request
Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo, otherwise LGTM from my end

@rbiseck3 rbiseck3 force-pushed the roman/cli-infer-table-arg branch from 6a0fbfb to f7e584d Compare October 9, 2023 14:55
Copy link
Contributor

@ryannikolaidis ryannikolaidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a quick test? either unit or simply throw that option in an ingest test with a doc that with results that differ based on the setting?

@rbiseck3 rbiseck3 force-pushed the roman/cli-infer-table-arg branch 2 times, most recently from 059078c to 5136a9d Compare October 11, 2023 14:31
CHANGELOG.md Outdated Show resolved Hide resolved
@ryannikolaidis
Copy link
Contributor

quick suggestion on the changelog otherwise gtg!

@rbiseck3 rbiseck3 force-pushed the roman/cli-infer-table-arg branch 3 times, most recently from 02bc7c5 to cfa8141 Compare October 11, 2023 20:08
Copy link
Contributor

@ryannikolaidis ryannikolaidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for grabbing this!

@rbiseck3 rbiseck3 force-pushed the roman/cli-infer-table-arg branch from 4093bcd to 67cbce4 Compare October 12, 2023 15:42
@rbiseck3 rbiseck3 enabled auto-merge October 12, 2023 15:45
@rbiseck3 rbiseck3 added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 9b5d5e0 Oct 12, 2023
39 checks passed
@rbiseck3 rbiseck3 deleted the roman/cli-infer-table-arg branch October 12, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants