-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Bag of words for testing metric #1650
Conversation
…into feat/local-embed-model
…O/unstructured into feat/bag-of-words
…into feat/bag-of-words
…O/unstructured into feat/bag-of-words
…O/unstructured into feat/bag-of-words
Could we add a test for text that contains incorrect spaces between words (like how the unstructured output looks sometimes)? for example in "i n t r o d u c t i o n", each letter will be considered its own word right? |
Are we sure we want to keep all punctuation?
|
No, we should not keep all punctuation, only punctuation within a word (hyphens and apostrophes). commas, dashes, between words or end of sentence punctuation should all be removed. |
Yes, |
…O/unstructured into feat/bag-of-words
…O/unstructured into feat/bag-of-words
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! thanks for taking care of all the punctuation cases :)
This PR adds the
bag_of_words
function to count the frequency of words for evaluation.Testing