-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: process chipper hierarchy #1634
Conversation
…ured-IO/unstructured into chore/process-chipper-hierarchy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ingest test diffs are caused by this change, and I think this is the sole source of diffs. |
Yes, that's right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR to support schema changes introduced from PR 232 in
unstructured-inference
.Specifically what needs to be supported is:
LayoutElement
fromunstructured-inference
is structured, specifically that this class is no longer a subclass ofRectangle
, and insteadLayoutElement
has abbox
property that captures the location information and afrom_coords
method that allows construction of aLayoutElement
directly from coordinates.LocationlessLayoutElement
since chipper now exports bounding boxes, and if we need to support elements without bounding boxes, we can make thebbox
property mentioned above optional.Testing:
The following demonstrates that the new version of chipper is inferring hierarchy.
Also verify that running the traditional
hi_res
gives different results: