-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add file-based access permissions for SharePoint ingest #1628
Conversation
…- ingest.sh and processor.py are modified temporarily
Potential improvements before merging:
|
Note: Reading permissions data as an object rather than a str causes proper formatting in the outputted elements.json file (rather than keeping the permissions data in one line), and results in permission data dominating / polluting the file. Repeating it for each element adds to the problem. Open to suggestions about this |
Note: Sharepoint seems to be having trouble with our parallel requests, giving:
or
To address this, I've reduced num-processes in the example .sh to 1, and it seems like this helps |
Example file for testing:
|
…ed-IO/unstructured into ahmet/sharepoint-rbac
…1722) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: ahmetmeleq <[email protected]>
…ed-IO/unstructured into ahmet/sharepoint-rbac
We're there now 👍 |
...tructured_ingest/expected-structured-output/Sharepoint/Shared Documents/ideas-page.html.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple nits on docs and a comment / followup on CliPermissionsConfig
Co-authored-by: ryannikolaidis <[email protected]>
Co-authored-by: ryannikolaidis <[email protected]>
Co-authored-by: ryannikolaidis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! nice work, I know this was a huge lift.
This PR:
To test the changes, run
examples/ingest/sharepoint/ingest.sh
with the relevant rbac & connector credentials