Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roman/drop downloads in ingest tests #1614

Merged
merged 6 commits into from
Oct 2, 2023

Conversation

rbiseck3
Copy link
Contributor

@rbiseck3 rbiseck3 commented Oct 2, 2023

Description

In an effort to mitigate resource consumption when running CI tests, cleanup download dir for ingest tests after each one.

Copy link
Contributor

@cragwolfe cragwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we only cleanup if the CI env var is defined? having downloaded files tends to be more useful for devs than not by default, i think

@rbiseck3
Copy link
Contributor Author

rbiseck3 commented Oct 2, 2023

I usually just comment that line out when running locally if I want to review the downloaded content.

@rbiseck3 rbiseck3 enabled auto-merge (squash) October 2, 2023 20:40
Copy link
Contributor

@cragwolfe cragwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving so as not to block, but i think the default for dev's really ought to be downloads exist locally (more useful debugging by default), with a super obvious switch to turn it off for those that are not used to running ingest all the time.

@rbiseck3 rbiseck3 merged commit 11cdd8d into main Oct 2, 2023
@rbiseck3 rbiseck3 deleted the roman/drop-downloads-in-cleanup-ingest-tests branch October 2, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants