feat: change default hi_res model to yolox quantized #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor the way to set default model for hi_res mode for image and pdf partition into a function that is callable and returns either an env varaible or a default model - this keeps the current pattern for setting the default hi_res model - change the default model name from `detectron2_onnx` to `yolox_quantized` - the new default mode has better recall for tables and richer categories for partitioned elements than detectron2
…ixtures update (#1618) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: badGarnet <[email protected]>
|
please review comments here for the ingest diff eval: #1618 |
benjats07
approved these changes
Oct 3, 2023
actually do we have gold label for those ingest test documents? if not maybe that is something we should have even before generating metrics |
qued
approved these changes
Oct 4, 2023
Co-authored-by: qued <[email protected]>
cragwolfe
pushed a commit
that referenced
this pull request
Oct 5, 2023
This PR was initially created to close GitHub Issue #1604 (Synchronizing the default layout model), but since it was already resolved in PR [#1607](#1607), this PR now only adds the visualization script used to investigate the issue. ### Summary - add python script to annotate elements PDF: [references.pdf](https://github.com/Unstructured-IO/unstructured/files/12778270/references.pdf) ### Evaluation ``` PYTHONPATH=. python examples/layout-analysis/visualization.py references.pdf hi_res ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detectron2_onnxtoyolox_quantized