Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: move scarf to setup.py #1569

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

tabossert
Copy link
Contributor

This also follows what I have seen as the recommend way to define a file package like this.

Also bumps minor versions from pip compile

Testing:
pip install -e .
Everything should build as normal

❯ pip install -e . Obtaining file:///Users/trevor/dev/unstructured Installing build dependencies ... done Checking if build backend supports build_editable ... done Getting requirements to build editable ... done Preparing editable metadata (pyproject.toml) ... done Collecting scarf@ https://packages.unstructured.io/scarf.tgz (from unstructured==0.10.17.dev16) Using cached https://packages.unstructured.io/scarf.tgz (1.1 kB) Installing build dependencies ... done Getting requirements to build wheel ... done Preparing metadata (pyproject.toml) ... done

When new release goes out, I will test just plain pip install to verify that functionality still works

This allows for running pip install -e . and regular pip install
Copy link
Contributor

@ryannikolaidis ryannikolaidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for fixing this!

@ryannikolaidis
Copy link
Contributor

tested locally with pip install -e . as well and everything worked as expected.

@tabossert tabossert merged commit 792232d into main Sep 28, 2023
@tabossert tabossert deleted the trevor/scarf-pip-local-install-fix branch September 28, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants