-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Better logic for setting category_depth
metadata for Title
elements
#1517
Merged
Merged
Changes from 8 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
881d1fe
fix: better logic for setting Title category_depth
LaverdeS 9214708
docs: update with last fix changes
LaverdeS aa948a8
chore: new dev version
LaverdeS aed91ca
fix: Title depth logic depend on Headline Subheadline
LaverdeS b82ead7
fix: catch exception for HTML objects with no type attr
LaverdeS aa38a94
chore: add test to corroborate the improvement for Titles
LaverdeS 28d3f30
chore: update description of the logic to correct depth of Titles
LaverdeS eed145a
Merge branch 'main' into sebastian/fix-title-depth
LaverdeS aff98bc
chore: add logging for HTML elements without type attr
LaverdeS 1a43fdb
fix: condition is True only if category_depth is None
LaverdeS be60650
Merge branch 'main' into sebastian/fix-title-depth
LaverdeS f9e4436
chore: update CHANGELOG.md
LaverdeS de387ad
chore: better description of fix in CHANGELOG
LaverdeS 27ce065
Merge branch 'main' into sebastian/fix-title-depth
LaverdeS cdced8e
Merge branch 'main' into sebastian/fix-title-depth
qued 40ea340
Merge branch 'main' into sebastian/fix-title-depth
LaverdeS 12ac02f
chore: tidyig
LaverdeS 6d86282
chore: update CHANGELOG.md
LaverdeS 6c2f012
docs: add Importance to changes in CHANGELOG.md
LaverdeS 18b5267
Merge branch 'main' into sebastian/fix-title-depth
LaverdeS a7d2959
Merge branch 'main' into sebastian/fix-title-depth
LaverdeS 4286f04
chore: update changes and dev version
LaverdeS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this make sense semantically?
remind me what the
category_depth
for anH1
element is again? if it is 0, does this imply all other Titles from Chipper are like htmlH1
's?Please add "Why does it matter? for the 2nd sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct,
H1
iscategory_depth
0. For,chipper
:Title
elements are likeH1
,Headline
likeH2
, andSubheadline
likeH3
. I am changing the description of the fix for clarification.