Discord fix when a channel is not found. #1480
Conversation
| if channel is None: | ||
| raise FileNotFoundError("Channel not found.") |
There was a problem hiding this comment.
do we know for a fact if this is None it's because the channel wasn't found versus a connectivity issue? asking because we hit the error earlier and it seemed to be an ephemeral issue, which would suggest the latter, right? I want to make sure we don't mislead the caller here.
There was a problem hiding this comment.
Based on a comment on the discord client we're using:
The returned channel or ``None`` if not found.
There was a problem hiding this comment.
Got it, but then why were we seeing that in CI intermittently? ...because obviously that channel didn't disappear/reappear.
There was a problem hiding this comment.
also probably good to drop a line to that documentation as comment in the code here, but probably helpful for us to understand why this is the case intermittently in CI. seems like some other case is also resulting in this being None (if None is what triggered the original error we were seeing)
|
looks like we have no actual changes at this point? I know this is still draft, assuming something is in progress? |
jump_urlget_channelfunction from the discord client returns None when the given channel couldn't be fetched or it doesn't exists.bot.get_channelonly once within the callback function used by the discord bot. If the fetching of the channel fails, we note it earlier.