fix: coordinates bug on pdf parsing #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cragwolfe
reviewed
Sep 19, 2023
| @@ -761,7 +761,7 @@ def check_coords_within_boundary( | |||
| a float ranges from [0,1] to scale the horizontal (x-axis) boundary | |||
| """ | |||
| if not coord_has_valid_points(coordinates) and not coord_has_valid_points(boundary): | |||
| raise ValueError("Invalid coordinates.") | |||
| return False | |||
There was a problem hiding this comment.
worth adding a trace detail message i think, like:
.
is there a single page this fails on that could be added to a test? one could extract the problematic page with something like:
qpdf --empty --pages orignal.pdf 89 -- ~/tmp/docs/single-page-p89.pdf
finally, does not need to be addressed in this PR, but what is the why for the invalid coordinate? is it negative values? (which i think are actually legit in PDF's in certain cases)
There was a problem hiding this comment.
Sounds good - I'll add trace detail and a test!
And yes - the values that it was erroring on were negative.
There was a problem hiding this comment.
here's where it was failing: https://github.com/Unstructured-IO/unstructured/blob/main/unstructured/partition/utils/sorting.py#L30
cragwolfe
reviewed
Sep 19, 2023
cragwolfe
reviewed
Sep 19, 2023
cragwolfe
reviewed
Sep 19, 2023
Co-authored-by: cragwolfe <[email protected]>
Co-authored-by: cragwolfe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #1460
We were raising an error with invalid coordinates, which prevented us from continuing to return the element and continue parsing the pdf. Now instead of raising the error we'll return early.
to test: