-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add makefile to requirements #1295
Conversation
why this is better than the existing solution? in the off chance that the existing but as long as pins are being kept in |
The current method relies on Makefile is designed to handle compilation dependency so I would argue that is the safest way to ensure pip-compile runs correctly. Now I do concede that with current requirements this may seem a bit over engineering. |
probably not needed for now |
reopen this PR because recently we have encountered a case where |
Got this: ❯ make pip-compile
scripts/pip-compile.sh: line 11: MAKE[1]:: command not found
cp: requirements/build.txt: No such file or directory
make: *** [pip-compile] Error 1 |
scripts/pip-compile.sh
Outdated
@@ -8,5 +8,5 @@ if ! python -c "import sys; assert sys.version_info.major == $major and sys.vers | |||
exit 1 | |||
fi | |||
|
|||
cd ./requirements && $(MAKE) *.txt | |||
cd ./requirements && make *.txt && cd .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can use pushd
/popd
to navigate to/from the requirements dir. Has some pleasantries: Navigating with popd
It looks like everything in the |
Also there used to be logic to copy the |
updated makefile to work on subdirectories and added back the copy line |
This PR resolves #1294 by adding a Makefile to compile requirements. This makefile respects the dependencies between file and will compile them in order. E.g., extra-*.txt will be compiled after base.txt is updated.
Test locally by simply running
make pip-compile
orcd requirements && make clean && make all