fix: added possibility of utilising namespaces #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped version
Removed test that would not work
|
I thought we already had support for namespaces? What does this PR solve? |
We did have it yes, but we never used it from platform perspective, only relying on default namespace behaviour so I wanted to add a test before we put this up in production as a feature (alongside minor refactors I did). Turns out my test fails, so I wonder about the functionality as a whole, trying to find if I was the problem or our upsert. |
|
Added passing test verifying that namespaces work correctly. Plus minor refactor in the upsert function and modified descriptions. |
rbiseck3
reviewed
Jan 8, 2025
rbiseck3
reviewed
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per request enabled the possibility of utilisng namespace in pinecone connector