feat: Migrate qdrant destination to V2 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbiseck3
reviewed
Oct 16, 2024
rbiseck3
reviewed
Oct 16, 2024
rbiseck3
added
needs edits
Refactor qdrant destination to use asynchronous SDK. Deprecate --num-processes due to switch to async. Update E2E test expectation to match V2 pipeline run. Introduce docker based integration test.
Remove Optional from fields which do not take None values. Fix referencing the moved collection_name parameter.
Test QdrantLocal in addition to Qdrant with docker server. Test for embedding by querying single point for similarity.
rbiseck3
force-pushed
the
DS-93-qdrant-destination-to-v2
branch
from
d80f82b to
dbdd72c
Compare
jaisir-shadai
pushed a commit
to shadai-group/shadai-rag-unstructured-ingest
that referenced
this pull request
Nov 10, 2024
* qdrant v1, changed t. typing import way * stager part not finihed yer * remove migrated function * conn not ready yet * fix Roman PR comments * make tidy * taking optional out from access config * make tidy * add secret to access config * taking api key to connection config * fix collection name. back api key to access config * version-secret * docslistt to element lict * printing writedict params * . * changing variablename. * Refactor to async Refactor qdrant destination to use asynchronous SDK. Deprecate --num-processes due to switch to async. Update E2E test expectation to match V2 pipeline run. Introduce docker based integration test. * Condense doc-string lines * Update parameter descriptions * Fix run_async signature * Remove E2E test in favor of integration. * Capitalize description * Fix collection_name calls and remove some incorrect Optionals Remove Optional from fields which do not take None values. Fix referencing the moved collection_name parameter. * Test QdrantLocal, test embedding Test QdrantLocal in addition to Qdrant with docker server. Test for embedding by querying single point for similarity. * Conform to 100 line limit * Fix test name * expand into different qdrant connectors per auth type * add server integration test --------- Co-authored-by: Filip Knefel <[email protected]> Co-authored-by: Roman Isecke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates qdrant destination connector to V2 and introduces an integration test for it.
Notable changes to V1:
--num-processes