Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/Migration - GitHub Source to Connector V2 Structure #157

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

feat/Migration - GitHub Source to Connector V2 Structure #157

wants to merge 62 commits into from
+503 −54

Conversation

unstructured-theron
Copy link
Contributor

@unstructured-theron unstructured-theron commented Oct 8, 2024 •
edited by ds-filipknefel
Loading

Changelog

  • Update expected outputs to support GitHub Source V2.
  • Refact the precheck method.
  • Migrate GitHub Source V1 to V2, adopting new interfaces: AccessConfig, Indexers, and Downloaders.

rbiseck3
rbiseck3 reviewed Oct 24, 2024
View reviewed changes
unstructured_ingest/v2/processes/connectors/github.py Outdated


Raises:
UnknownObjectException: If the file does not exist in the repository.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text is no longer accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done;

rbiseck3
rbiseck3 reviewed Oct 24, 2024
View reviewed changes
unstructured_ingest/v2/processes/connectors/github.py Outdated
bytes: The content of the file as bytes.

Raises:
UnknownObjectException: If the download or content retrieval fails.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text is no longer accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done;

@potter-potter potter-potter added ready for review This PR is complete and ready for a review and removed v2 migration needs edits This PR has been reviewed and needs edits to be complete labels Nov 7, 2024
@rbiseck3 rbiseck3 added needs edits This PR has been reviewed and needs edits to be complete and removed ready for review This PR is complete and ready for a review labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbiseck3 rbiseck3 rbiseck3 left review comments

@vangheem vangheem Awaiting requested review from vangheem

@ahmetmeleq ahmetmeleq Awaiting requested review from ahmetmeleq

@potter-potter potter-potter Awaiting requested review from potter-potter

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs edits This PR has been reviewed and needs edits to be complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate github connector to v2
4 participants
@unstructured-theron @potter-potter @rbiseck3 @bryan-unstructured