Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ValueError when converting cells to html #359

Merged
merged 3 commits into from
Jun 21, 2024
Merged

fix: ValueError when converting cells to html #359

merged 3 commits into from
Jun 21, 2024

Conversation

christinestraub
Copy link
Contributor

@christinestraub christinestraub commented Jun 21, 2024 •
edited
Loading

This PR will address #357, #358, and Unstructured-IO/unstructured#3252.

Summary

  • add logic to validate the input parameter to the fill_cells() function. Now, the function checks if the input is a valid list of dictionaries before processing.
  • correct type hint for parameter cells in table_cells_to_dataframe()

@christinestraub
feat: add input parameter validation to fill_cells()
97e132b 
Added logic to validate the input parameter to the fill_cells() function.
Now, the function checks if the input is a list of dictionaries before processing.
@christinestraub
fix: correct type hint for parameter cells in `table_cells_to_dataf…
c6e8d33 
…rame()`
@christinestraub
chore: update changelog & version
e783507
MthwRobinson
MthwRobinson approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christinestraub christinestraub merged commit 662571a into main Jun 21, 2024
5 checks passed
@christinestraub christinestraub deleted the fix/cells-to-html branch June 21, 2024 22:18
This was referenced Jun 24, 2024
Closed
Closed
Closed
Closed
@christinestraub christinestraub mentioned this pull request Jul 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MthwRobinson MthwRobinson MthwRobinson approved these changes

@cragwolfe cragwolfe Awaiting requested review from cragwolfe

@badGarnet badGarnet Awaiting requested review from badGarnet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christinestraub @MthwRobinson