-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/219 keep extracted image elements #225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracted image elements
# Conflicts: # CHANGELOG.md # unstructured_inference/__version__.py
badGarnet
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- confirmed this is working and on example pdf gets all the images
- test instruction has typos 😬 (path should be
image_extraction
notimage-extraction
- not related to this PR but worth a followup ticket/issue: refactor the logic for
inferred_is_text
so it is more modular instead of buried in the long chain of function
christinestraub
added a commit
that referenced
this pull request
Sep 26, 2023
benjats07
pushed a commit
that referenced
this pull request
Sep 30, 2023
update `merge_inferred_layout_with_extracted_layout` to keep extracted image elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #219.
Summary
merge_inferred_layout_with_extracted_layout
to keep extracted image elementsThe following documents can be used for testing and evaluation.
Testing
Evaluation