Skip to content

Commit

Permalink
Suppress kwargs when not used
Browse files Browse the repository at this point in the history
  • Loading branch information
qued committed Oct 20, 2023
1 parent ebb86c4 commit 90072b7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 23 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## 0.7.10-dev2

* Handle kwargs related to pdf processing in signature
* Handle kwargs explicitly when needed, suppress otherwise
* fix: Reduce Chipper memory consumption on x86_64 cpus
* fix: Skips ordering elements coming from Chipper
* fix: After refactoring to introduce Chipper, annotate() weren't able to show text with extra info from elements, this is fixed now.
Expand Down
22 changes: 0 additions & 22 deletions unstructured_inference/inference/layout.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,8 @@ def from_pages(cls, pages: List[PageLayout]) -> DocumentLayout:
def from_file(
cls,
filename: str,
detection_model: Optional[UnstructuredObjectDetectionModel] = None,
element_extraction_model: Optional[UnstructuredElementExtractionModel] = None,
fixed_layouts: Optional[List[Optional[List[TextRegion]]]] = None,
extract_tables: bool = False,
pdf_image_dpi: int = 200,
extract_images_in_pdf: bool = False,
image_output_dir_path: Optional[str] = None,
**kwargs,
) -> DocumentLayout:
"""Creates a DocumentLayout from a pdf file."""
Expand Down Expand Up @@ -110,13 +105,8 @@ def from_file(
image,
number=i + 1,
document_filename=filename,
detection_model=detection_model,
element_extraction_model=element_extraction_model,
layout=layout,
fixed_layout=fixed_layout,
extract_tables=extract_tables,
extract_images_in_pdf=extract_images_in_pdf,
image_output_dir_path=image_output_dir_path,
**kwargs,
)
pages.append(page)
Expand Down Expand Up @@ -457,12 +447,6 @@ def from_image(
def process_data_with_model(
data: BinaryIO,
model_name: Optional[str],
is_image: bool = False,
fixed_layouts: Optional[List[Optional[List[TextRegion]]]] = None,
extract_tables: bool = False,
pdf_image_dpi: int = 200,
extract_images_in_pdf: bool = False,
image_output_dir_path: Optional[str] = None,
**kwargs,
) -> DocumentLayout:
"""Processes pdf file in the form of a file handler (supporting a read method) into a
Expand All @@ -473,12 +457,6 @@ def process_data_with_model(
layout = process_file_with_model(
tmp_file.name,
model_name,
is_image=is_image,
fixed_layouts=fixed_layouts,
extract_tables=extract_tables,
pdf_image_dpi=pdf_image_dpi,
extract_images_in_pdf=extract_images_in_pdf,
image_output_dir_path=image_output_dir_path,
**kwargs,
)

Expand Down

0 comments on commit 90072b7

Please sign in to comment.