build: add python 3.12 to wolfi-base #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabossert
reviewed
Sep 9, 2024
| @@ -6,7 +6,6 @@ COPY ./scripts/install-wolfi-tesseract.sh install-wolfi-tesseract.sh | |||
|
|
|||
| USER root | |||
| RUN apk update && \ | |||
| apk del python-3.12 && \ | |||
| apk add py3.11-pip mesa-gl glib cmake bash libmagic wget git openjpeg && \ | |||
There was a problem hiding this comment.
should this be py3.12-pip? @MthwRobinson
There was a problem hiding this comment.
Added py3.12-pip in there. Figured we can keep py3.11-pip in there now as well so we can still upgrade 3.11 if 3.12 doesn't work for whatever reason
There was a problem hiding this comment.
Looks like you can only have either one or the other ... 3.12 it is!
There was a problem hiding this comment.
Added py3.12-pip in there.
@MthwRobinson Does this mean we don't need to explicitly add py3.12-pip like py3.11-pip?
tabossert
approved these changes
Sep 9, 2024
christinestraub
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Python 3.12 to
wolfi-baseto support bumping theunstructuredandunstructured-apiimages to the 3.12. This PR also temporarily disables the rocky builds because failures in those jobs were blocking the wolfi builds.