Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional packages to wolfi-base #40

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

christinestraub
Copy link
Contributor

@christinestraub christinestraub commented Aug 12, 2024

Summary

This PR addresses the following issues:

@cragwolfe
Copy link
Contributor

Could this be a new wolfi-dev image that uses wolfe-base as the base?

@MthwRobinson
Copy link
Contributor

Yeah agree with @cragwolfe to avoid bloating the production images. Another option could be to install those additional dependency just in the image you're working on, and uninstall them and the end if the -dev dependencies aren't needed at runtime.

Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christinestraub christinestraub merged commit 82e1186 into main Aug 13, 2024
@christinestraub christinestraub deleted the build/add-additional-packages-to-wolfi-base branch August 13, 2024 16:37
@christinestraub christinestraub restored the build/add-additional-packages-to-wolfi-base branch August 13, 2024 16:39
christinestraub added a commit that referenced this pull request Aug 13, 2024
@christinestraub christinestraub deleted the build/add-additional-packages-to-wolfi-base branch August 13, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants