Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS-35 Feat/push base images with hash in tag #30

Merged
merged 12 commits into from
Jun 26, 2024
+16 −8
Merged

OSS-35 Feat/push base images with hash in tag #30

Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ae45ddf
add job to make pr to downstream
badGarnet Jun 21, 2024
a58c446
refactor publication
badGarnet Jun 21, 2024
ba0aab9
fix syntax in workflow
badGarnet Jun 21, 2024
9536b87
remove unused block of testing job
badGarnet Jun 21, 2024
f313b85
fix env syntax
badGarnet Jun 21, 2024
d4b8782
simplify experiment
badGarnet Jun 24, 2024
a038add
remove dep for testing
badGarnet Jun 24, 2024
091e907
fix: fix if syntax
badGarnet Jun 25, 2024
843db88
revert testing changes
badGarnet Jun 25, 2024
fe1ada4
revert more testing changes
badGarnet Jun 25, 2024
f6de694
feat: use short hash to tag rocky linux image as well
badGarnet Jun 26, 2024
cca68f5
rename the rocky linux folders to match new image tag
badGarnet Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,18 +83,30 @@ jobs:
password: ${{ secrets.QUAY_IO_ROBOT_TOKEN }}
- name: Pull AMD image
run: |
docker pull --platform linux/amd64 $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-amd64-$SHORT_SHA
docker pull --platform linux/amd64 $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-amd64
docker tag $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-amd64-$SHORT_SHA $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-amd64
docker push $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-amd64
- name: Pull ARM image
run: |
docker pull --platform linux/arm64 $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-arm64-$SHORT_SHA
docker pull --platform linux/arm64 $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-arm64
docker tag $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-arm64-$SHORT_SHA $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-arm64
docker push $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-arm64
- name: Push multiarch manifest
run: |
docker manifest create $DOCKER_REPOSITORY/$DOCKER_IMAGE:${{ matrix.image }} $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-amd64 $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-arm64
docker manifest push $DOCKER_REPOSITORY/$DOCKER_IMAGE:${{ matrix.image }}
if [[ ${{ matrix.image }} == 'wolfi-base' ]]; then
export IMAGE_TAG=${{ matrix.image }}-$SHORT_SHA
else
export IMAGE_TAG=${{ matrix.image }}
fi
docker manifest create $DOCKER_REPOSITORY/$DOCKER_IMAGE:${IMAGE_TAG} $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-amd64 $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-arm64
docker manifest push $DOCKER_REPOSITORY/$DOCKER_IMAGE:${IMAGE_TAG}
- name: Push latest manifest for wolfi base
if: ${{ matrix.image }} == 'wolfi-base'
run: |
docker manifest create $DOCKER_REPOSITORY/$DOCKER_IMAGE:${IMAGE_TAG} $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-amd64 $DOCKER_BUILD_REPOSITORY:${{ matrix.image }}-arm64
docker manifest push $DOCKER_REPOSITORY/$DOCKER_IMAGE:${IMAGE_TAG}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do that in 1 step if you use if-else in bash anyway

env:
IMAGE_TAG: wolfi-base-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easier to read when env is before run


shellcheck:
runs-on: ubuntu-latest
Expand Down
Loading