GHA - Replace Vercel bash deploy script by "deploy-on-vercel" github action #296
Conversation
|
✅ Deployment SUCCESS |
|
✅ E2E tests SUCCESS for commit d6e28ee previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-le9gfznxk-unly-oss.vercel.app |
| VERCEL_DEPLOYMENT_DOMAIN=${{ env.VERCEL_DEPLOYMENT_DOMAIN }} | ||
| VERCEL_DEPLOYMENT_URL=${{ format('https://{0}', env.VERCEL_DEPLOYMENT_DOMAIN) }} |
There was a problem hiding this comment.
Shouldn't the VERCEL_DEPLOYMENT_URL and VERCEL_DEPLOYMENT_DOMAIN both be returned by the Action?
There was a problem hiding this comment.
That'd avoid doing the above which isn't dev-friendly
package.json
Outdated
| "deploy:ci:gha": "yarn vercel:cleanup && yarn vercel:deploy --local-config=vercel.${CUSTOMER_REF}.staging.json", | ||
| "deploy:ci:gha:production": "yarn vercel:cleanup && yarn vercel:deploy --local-config=vercel.${CUSTOMER_REF}.production.json --prod", | ||
| "deploy:ci:gha": "yarn vercel:deploy --local-config=vercel.${CUSTOMER_REF}.staging.json", | ||
| "deploy:ci:gha:production": "CUSTOMER_REF=${CUSTOMER_REF} yarn vercel:deploy --local-config=vercel.${CUSTOMER_REF}.production.json --prod", |
There was a problem hiding this comment.
Why CUSTOMER_REF=${CUSTOMER_REF} ? Doesn't seem necessary, and it's confusing because the above command doesn't define it.
There was a problem hiding this comment.
Mistake, I removed it from staging but not production
|
✅ Deployment SUCCESS |
|
✅ E2E tests SUCCESS for commit fc46206 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-7u1iwwx5h-unly-oss.vercel.app |
|
✅ E2E tests SUCCESS for commit fc46206 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-p5o6y2e1z-unly-oss.vercel.app |
Vadorequest
changed the title
|
✅ Deployment SUCCESS |
|
✅ E2E tests SUCCESS for commit ebc9339 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-c1kchq71l-unly-oss.vercel.app |
…c24a6429fdd257598df2017 (v1.0.0) instead of latest
|
✅ Deployment SUCCESS |
|
✅ Deployment SUCCESS |
|
✅ E2E tests SUCCESS for commit 145a048 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-cgqfx5fhx-unly-oss.vercel.app |
|
✅ E2E tests SUCCESS for commit 145a048 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-36djmkawr-unly-oss.vercel.app |
|
✅ Deployment SUCCESS |
|
✅ Deployment SUCCESS |
|
✅ E2E tests SUCCESS for commit 7cc8a1b previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-1pu42m809-unly-oss.vercel.app |
|
✅ E2E tests SUCCESS for commit 7cc8a1b previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-4ujwkei3y-unly-oss.vercel.app |
…action (#296) Co-authored-by: Dhenain Ambroise <[email protected]>
Co-authored-by: Dhenain Ambroise <[email protected]>
Co-authored-by: Dhenain Ambroise <[email protected]>
Reduce the complexity of the Vercel deployment script (GitHub Actions) by using a dedicated action instead of the existing bash script.
Makes the code much more readable, remove code duplication (x3) in various actions.