-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps - Upgrade to Emotion v11 (from v10) [BREAKING CHANGES] #247
Conversation
…e "css" issue with Emotion 11 - See https://emotion.sh/docs/emotion-11#css-prop-types
✅ Deployment SUCCESS |
…typescript#css-prop) + fix new TS issue (unknown, ignored)
…ss/ subfolder, not main tsconfig.json
…move /// <reference types="@emotion/react/types/css-prop" />
✅ Deployment SUCCESS |
❌ E2E tests FAILED for commit 914996e previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-r3mj5u31t.vercel.app |
✅ E2E tests SUCCESS for commit 914996e previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-r3mj5u31t.vercel.app |
❌ Deployment FAILED |
…splayed on failure only (bad copy/paste)
✅ Deployment SUCCESS |
❌ E2E tests FAILED for commit 210da53 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-4fo1vx0jw.vercel.app |
✅ E2E tests SUCCESS for commit 210da53 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-4fo1vx0jw.vercel.app |
✅ Deployment SUCCESS |
✅ E2E tests SUCCESS for commit 797b66a previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-3a8og8kyo.vercel.app |
✅ Deployment SUCCESS |
✅ E2E tests SUCCESS for commit a103326 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-p970ki06e.vercel.app |
…odified, conflicts solved)
See https://emotion.sh/docs/emotion-11
Changes
Breaking changes with
useTheme
due to Emotion TS changesconst customerTheme = useTheme<CustomerTheme>();
const customerTheme = useTheme();
,useTheme
doesn't support dynamic type anymore, as it's now handled for the whole app insrc/types/emotion-theme.ts
instead.Status
All blocking issues have been fixed, ready for merge. Works locally and on Vercel.
Issues
Both issues were related to webpack/babel configuration and were solved thanks to Andarist