-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade v2-mst-aptd-gcms-lcz-sty
preset to Next.js 10
#190
Conversation
v2-mst-aptd-gcms-lcz-sty
preset to Next.js 10
✅ Deployment SUCCESS |
❌ Deployment FAILED |
1 similar comment
❌ Deployment FAILED |
✅ Deployment SUCCESS |
✅ E2E tests SUCCESS for commit e39c13a previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-qenazwfm5.vercel.app |
❌ E2E tests FAILED for commit 3dd17be previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-3zd8v3wud.vercel.app |
…the Emotion "css" props (@emotion/babel-preset-css-prop) - See vercel/next.js#18461 (comment)
✅ Deployment SUCCESS |
✅ E2E tests SUCCESS for commit f874e94 previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-o2nslci9o.vercel.app |
Goal:
Upgrade the
v2-mst-aptd-gcms-lcz-sty
preset to Next.js 10. See https://nextjs.org/blog/next-10Major deps updates:
Encountered issues:
react@latest react-dom@latest
crashes withpragma and pragmaFrag cannot be set when runtime is automatic.
pragma has been set but pragmaFrag has not been set
vercel/next.js#18461 (comment) did workNon-backward compatible changes:
/** @jsx jsx */
anymore, because doing so isn't compatible with the new babelautomatic
JSX Transform./** @jsxFrag React.Fragment */
(NRN didn't use it, but you might)jsx
from'@emotion/core'
are to be removed (unused)Noticeable changes:
babel.config.js
file had to be added, to provide support of the newautomatic
JSX Transform with EmotionResources: