Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade v2-mst-aptd-gcms-lcz-sty preset to Next.js 10 #190

Merged
merged 7 commits into from
Oct 30, 2020

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented Oct 30, 2020

Goal:

Upgrade the v2-mst-aptd-gcms-lcz-sty preset to Next.js 10. See https://nextjs.org/blog/next-10

Major deps updates:

  • Next 9 > 10.0.0
  • React 16 > 17

Encountered issues:

Non-backward compatible changes:

  • It is not possible to use the JSX pragma /** @jsx jsx */ anymore, because doing so isn't compatible with the new babel automatic JSX Transform.
    • Same goes for /** @jsxFrag React.Fragment */ (NRN didn't use it, but you might)
    • Also, all references of jsx from '@emotion/core' are to be removed (unused)
    • Overall, that's a good news, less boilerplate code to use Emotion.

Noticeable changes:

Resources:

@Vadorequest Vadorequest changed the title Next 10 gcms Upgrade v2-mst-aptd-gcms-lcz-sty preset to Next.js 10 Oct 30, 2020
@github-actions
Copy link

✅  Deployment SUCCESS
Commit 3dd17be successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-85doau5v0.vercel.app
Deployment aliased as v2-mst-aptd-gcms-lcz-sty.vercel.app

@github-actions
Copy link

❌  Deployment FAILED
Commit 4c48186 failed to deploy to
click to see logs

1 similar comment
@github-actions
Copy link

❌  Deployment FAILED
Commit 4c48186 failed to deploy to
click to see logs

@github-actions
Copy link

✅  Deployment SUCCESS
Commit e39c13a successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-qenazwfm5.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-c1-next-10-g.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit e39c13a previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-qenazwfm5.vercel.app

@github-actions
Copy link

❌  E2E tests FAILED for commit 3dd17be previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-3zd8v3wud.vercel.app
Download artifacts (screenshots + videos) from checks section

…the Emotion "css" props (@emotion/babel-preset-css-prop) - See vercel/next.js#18461 (comment)
@github-actions
Copy link

✅  Deployment SUCCESS
Commit f874e94 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-o2nslci9o.vercel.app
Deployment aliased as nrn-v2-mst-aptd-gcms-lcz-sty-c1-next-10-g.vercel.app

@github-actions
Copy link

✅  E2E tests SUCCESS for commit f874e94 previously deployed at https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-o2nslci9o.vercel.app

@Vadorequest Vadorequest marked this pull request as ready for review October 30, 2020 08:59
@Vadorequest Vadorequest merged commit 0806fd9 into v2-mst-aptd-gcms-lcz-sty Oct 30, 2020
@Vadorequest Vadorequest deleted the next-10-gcms branch October 30, 2020 09:00
@Vadorequest Vadorequest self-assigned this Oct 30, 2020
@Vadorequest Vadorequest added the enhancement New feature or request label Oct 30, 2020
@Vadorequest Vadorequest linked an issue Oct 30, 2020 that may be closed by this pull request
@Vadorequest Vadorequest mentioned this pull request Oct 30, 2020
@Vadorequest Vadorequest mentioned this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js 10
1 participant