Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:release templates strategy interaction improvements #8992

Merged
merged 3 commits into from
Dec 17, 2024
+3 −1
Merged

feat:release templates strategy interaction improvements #8992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a36b88
chore: pointer cursor for add strategy menu
daveleek Dec 17, 2024
1221d44
chore: close strategy dialog when esc or clicking outside
daveleek Dec 17, 2024
f46cebf
chore: remove console log
daveleek Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/component/releases/ReleasePlanTemplate/MilestoneStrategyMenuCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const StyledName = styled(StringTruncator)(({ theme }) => ({

const StyledCard = styled('div')(({ theme }) => ({
display: 'grid',
cursor: 'pointer',
gridTemplateColumns: '3rem 1fr',
width: '20rem',
padding: theme.spacing(2),
Expand Down
1 change: 0 additions & 1 deletion frontend/src/component/releases/ReleasePlanTemplate/MilestoneStrategySegmentList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ export const MilestoneStrategySegmentList = ({
const lastSegmentIndex = segments.length - 1;

if (segments.length === 0) {
console.log('segments.length === 0');
return null;
}

Expand Down
2 changes: 2 additions & 0 deletions frontend/src/component/releases/ReleasePlanTemplate/TemplateForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ export const TemplateForm: React.FC<ITemplateFormProps> = ({
<SidebarModal
label='Add strategy to template milestone'
onClose={() => {
setAddUpdateStrategyOpen(false);
setStrategyModeEdit(false);
}}
open={addUpdateStrategyOpen}
Expand All @@ -205,6 +206,7 @@ export const TemplateForm: React.FC<ITemplateFormProps> = ({
onAddUpdateStrategy={addUpdateStrategy}
onCancel={() => {
setAddUpdateStrategyOpen(false);
setStrategyModeEdit(false);
}}
editMode={strategyModeEdit}
/>
Expand Down
Loading