Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use strategyName instead of name property for component to load #8983

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix: use strategyName instead of name property for component to load #8983

merged 1 commit into from
Dec 16, 2024

Conversation

daveleek
Copy link
Contributor

resolves which component to load based on strategyName instead of name, as the former is always present

Skjermbilde 2024-12-16 kl 08 38 49

after switch

Skjermbilde 2024-12-16 kl 08 39 11

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 7:42am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Dec 16, 2024 7:42am

@github-actions GitHub Actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@daveleek daveleek requested review from chriswk and nunogois December 16, 2024 07:42
gastonfournier
gastonfournier approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@daveleek daveleek merged commit 76dfa3c into main Dec 16, 2024
13 checks passed
@daveleek daveleek deleted the fix/ui-couldnt-resolve-strategy-name branch December 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonfournier gastonfournier gastonfournier approved these changes

@chriswk chriswk Awaiting requested review from chriswk

@nunogois nunogois Awaiting requested review from nunogois

Assignees

@daveleek daveleek

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daveleek @gastonfournier