Feat/refactor polling #8976
Merged
Feat/refactor polling #8976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
@FredrikOseberg, core features have been modified in this pull request. Please review carefully! |
github-actions
bot
requested review from
chriswk,
gastonfournier and
ivarconr
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
sjaanus
reviewed
Dec 13, 2024
| ]; | ||
| const newToggles = await this.getChangedToggles( | ||
| changedToggles, | ||
| latestRevision, // TODO: this should come back from the same query to not be out of sync |
There was a problem hiding this comment.
This looks ok, but I was thinking about if we might not want to return the revisionId, from query .
Because the flow is getMaxRevisionId(), based on which we get the events, and if now with those events, go pull data and revision ID has changed, it will get out sync. I think best is
If we getMaxRevisionId, we use that across all the calls we make.
sjaanus
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the method that listens on revision changes:
Discussion point
In the listen method, should we implement logic to look into which environments the events touched? By doing this we would: