Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make project ui query optimized #8961

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix: make project ui query optimized #8961

merged 1 commit into from
Dec 12, 2024

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Dec 11, 2024

From 13 seconds to 0.1 seconds.

  1. Joining 1 million events to projects/features is slow. Solved by using CTE.
  2. Running grouping on 1 million rows is slow. Solved by adding index.

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:44am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Dec 11, 2024 0:44am

@github-actions GitHub Actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

chriswk
chriswk approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, wasn't aware you could do order on column on index creation.

gastonfournier
gastonfournier approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Make sure we still return the same data, but 👏

@sjaanus sjaanus merged commit 17d3b5c into main Dec 12, 2024
13 of 14 checks passed
@sjaanus sjaanus deleted the project-ui-query branch December 12, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastonfournier gastonfournier gastonfournier approved these changes

@chriswk chriswk chriswk approved these changes

Assignees

@sjaanus sjaanus

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjaanus @chriswk @gastonfournier